moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
315 stars 128 forks source link

Does not work with Angular 6 #93

Closed JustACodeMonkey closed 6 years ago

JustACodeMonkey commented 6 years ago

I'm submitting a ... (check one with "x")

[X ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/HackedByChinese/ng2-idle/blob/master/CONTRIBUTING.md#getting-help

Current behavior

Building an application with Angular 6 / Angular 6 CLI fails because Angular 6 required rxjs 6+.

Expected behavior

The application build should not fail

Minimal reproduction of the problem with instructions

Create an Angular 6 application with the Angular 6 CLI. Add @ng-idle/core to the dependencies section of package.json and try to run your application. You will see a series of errors in the format...

Module not found: Error: Can't resolve 'rxjs/Observable' in [.../node_modules/@ng-idle/core/src]

What is the motivation / use case for changing the behavior?

Our applications use @ng-idle/core and @ng-idle/keepalive and we're upgrading to Angular 6

Please tell us about your environment:

Mac OS (newest), VSCode (newest), npm, nodejs

JustACodeMonkey commented 6 years ago

There aren't too many changes required to make this work with Angular 6.

interrupt.ts (modules/core/src)

eventtargetinterruptsource.ts (modules/core/src)

...I updated the tslint.json file by removing the restriction to import the root of rxjs, and package.json accordingly (to update to newest version of Angular and RxJS).

dynamics12 commented 6 years ago

Any plans on supporting RxJS 6 anytime soon?

JustACodeMonkey commented 6 years ago

See the workaround https://github.com/HackedByChinese/ng2-idle/pull/94

goat67 commented 6 years ago

Can we get an updated version for angular 6??