search

morilog / jalali

This Package helps developers to easily work with Jalali (Shamsi or Iranian) dates in php appliations, based on Jalali (Shamsi) DateTime class.
MIT License
860 stars 110 forks source link

Wrong weekOfMonth for a date #145

Closed aramhuseiny closed 2 years ago

aramhuseiny commented 2 years ago

Hi, Thank you for this powerful package you made.

I try to use weekOfMonth method for a specific date, but I found there is a mistake in the formula that calculates that.

aramhuseiny commented 2 years ago

I checked the formula, This is the current one that calculates wrong ceil(($this->getDayOfWeek() + $this->day) / 7); I think you can use this that I suggest: floor(($this->day + 7 - $this->getDayOfWeek()) / 7) + 1

aramhuseiny commented 2 years ago

Actually the base value of "7" is not valid in all cases. New formula should be like this: floor(($this->day + 5 - $this->getDayOfWeek()) / 7) + 1