morilog / jalali

This Package helps developers to easily work with Jalali (Shamsi or Iranian) dates in php appliations, based on Jalali (Shamsi) DateTime class.
MIT License
860 stars 110 forks source link

مشکل در subMonths #71

Closed SadeghPM closed 4 years ago

SadeghPM commented 5 years ago

درود.

طبق مثال readme :

$date = (new Jalalian(1397, 1, 18))->subMonths(1)->toString() 
// output: 1396-12-18 00:00:00

اما اگر همین مثال رو اجرا کنید جوابی که میگیرید متفاوت هست.

>>> (new  Morilog\Jalali\Jalalian(1397, 1, 18))->subMonths(1)->toString()
=> "1397-01-18 00:00:00"
dena-a commented 5 years ago

Hello @morilog, This bug has been fixed on pull request #72 . Please merge. Thanks

skhalili commented 4 years ago

There is this bug and fixed by pull request #72

morilog commented 4 years ago

the pull request closed because of CI has been failed

dena-a commented 4 years ago

@skhalili The bug fixed on pull request #73. The issue has been solved. @morilog Please close the issue.