morincer / teamcity-plugin-saml

The plug-in adds ability to authenticate users by SAML-based SSO providers (like Okta, Onelogin etc.)
MIT License
24 stars 16 forks source link

Disabling the plugin throws an error message if saml has been added as an auth method #130

Open joakimkingstrom opened 4 months ago

joakimkingstrom commented 4 months ago

Hi,

We're currently in the process of starting to use this plugin and figured I'd report a minor issue we've had.

We're using it in our staging environment and we had also configured it in our prod environment, but hadn't yet enabled it. We restarted the prod TC server this morning and after that TC was showing the below error message:

"Failed to enable authentication module: HTTP-SAML.v2, error: Cannot find authentication module for type: HTTP-SAML.v2. Please check the corresponding plugin is installed."

It looks like this was caused by the plugin having been enabled, saml added as an auth method, configured, and after that the plugin having been disabled.

To make the error disappear I had to enable the plugin again, re-add it as an auth method, delete it as an auth method, and then disable it.

We haven't restarted TC again, so I suppose it might be possible that the error re-appears unless we also clear the config of it before disabling it, but the point is that disabling it should be enough IMO.

Kind regards, Joakim