search

morincer / teamcity-plugin-saml

The plug-in adds ability to authenticate users by SAML-based SSO providers (like Okta, Onelogin etc.)
MIT License
24 stars 16 forks source link

Use MANAGE_AUTHENTICATION_SETTINGS permission in SamlSettingsAdminPag… #56

Closed dmitry-treskunov closed 4 years ago

dmitry-treskunov commented 4 years ago

In TeamCity 2020.1.1 a new permission was introduced: MANAGE_AUTHENTICATION_SETTINGS, it makes sense to use instead of CHANGE_SERVER_SETTINGS

This will allow the plugin to be used in TeamCity Cloud where all users don't have CHANGE_SERVER_SETTINGS permission

dmitry-treskunov commented 4 years ago

Thanks, updated. Sorry, it's not easy to create a meaningful test for this change, because now the behavior depends on the TeamCity version and it's hard to emulate it in a test.

But if you think we need a test, then I can try to come up with something.