morincer / teamcity-plugin-saml

The plug-in adds ability to authenticate users by SAML-based SSO providers (like Okta, Onelogin etc.)
MIT License
24 stars 16 forks source link

Support authenticating on Secondary servers #62

Closed fatmcgav closed 3 years ago

fatmcgav commented 3 years ago

So I'm not sure if this is a change required to this plugin, TeamCity, or both.

However currently it appears that this plugin does not run on Seconday servers. This makes it impossible to login to a secondary server using SAML authentication.

A couple of links of note:

morincer commented 3 years ago

@fatmcgav , thanks for reporting - I had no idea about the secondary nodes in TC :) I'll take a look on them first week of Jan and get back with results.

fatmcgav commented 3 years ago

@morincer no worries.

From a quick read of the docs above, it might be as simple as just adding the additional attribute to the teamcity-plugin.xml... Or it might require some code changes to use jetbrains.buildServer.serverSide.IOGuard...

morincer commented 3 years ago

Well, it wasn't just that :) Add support for secondary nodes, did some basic testing. There are few limitations though - added section into Readme

fatmcgav commented 3 years ago

Awesome, thanks for the quick turnaround there @morincer .

Will give the new release a test...