morinel / gcmpush

Titanium Module for Android Push
Apache License 2.0
57 stars 35 forks source link

Added ADM support #53

Open manojdcoder opened 8 years ago

manojdcoder commented 8 years ago

Added ADM support for Amazon Kindle Fire devices.

DaKaZ commented 8 years ago

We worked with Manoj to create this PR - I can confirm that it is working great and our app was approved by Amazon and in their app store. Would be great to see this merged with the master for long term maintenance.

morinel commented 8 years ago

Thanks for the PR. I noticed you moved all code to an android subdir which I don't particularly like when merging changes.

Additionally:

manojdcoder commented 8 years ago

@morinel When I cloned the repo, I followed everything you had in ReadMe but it was never working and kept throwing errors during build. So I had to rebase the module with Studio, as you know Studio always injects android folder at root level and keeps all unique source files for Android there.

Additionally:

DaKaZ commented 7 years ago

I am not 100% positive (I can test if you want) but for this issue:

Storing an API key in a file in a module is of course not really developer friendly. Isn't there another way? ADM gives us 2 options, one we have to use a text file and another, the developer must sign his app with Amazon store, with Amazon's signature / key store. Developer can delete that text file (for api key) if he signs his app with Amazon

I believe the api key text file can be included in the main project and does not need to be included in the module. Let me know if you want me to test and I will.

Thanks