Use std::sample in the holdout_validation::init procedure

morinim / vita

Vita - Genetic Programming Framework

Mozilla Public License 2.0

36 stars 6 forks source link

Use std::sample in the holdout_validation::init procedure #20

Closed morinim closed 4 years ago

morinim commented 6 years ago

std::sample is computationally simpler and more direct than the current approach (std::shuffle + std::move).

morinim commented 4 years ago

Sampling is performed in place so std::sample isn't appropriate. Performance issue is already been resolved with ad-hoc partial Fisher-Yates sampling.