bug fix: default values in get_manta_sv

[Kdreval]

There was a discrepancy in how get_manta_sv() worked when no metadata was provided since the approach in id_ease has changed. This small PR resolves the issue.

[Kdreval]

This resolves the #6

[vladimirsouza]

There is an error when I run devtools:check() and I don't think it is related to this PR. The error also happen in my main branch.

Error in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]) : 
  there is no package called ‘GAMBLR’
Calls: <Anonymous> ... loadNamespace -> withRestarts -> withOneRestart -> doWithOneRestart
Execution halted
ERROR: lazy loading failed for package ‘GAMBLR.results’

Do you get this error as well?

[vladimirsouza]

This repo is not related to GAMBLR, and my GAMBLR is working fine!

[Kdreval]

0 errors ✔ | 0 warnings ✔ | 6 notes ✖

I think this means that the documentation in one of the functions is not up-to-date since it refers somewhere to GAMBLR that your check picked up. I run the check with no vignettes, no examples arguments

[vladimirsouza]

Got the very same error message with devtools::check(vignettes = FALSE, args = '--no-examples')

[Kdreval]

Interesting! Have you already uninstalled GAMBLR (the main repo)?

[vladimirsouza]

I can't understand yet why this error but I realized that I had used git checkout to a old commit in GAMBLR. then I git checkouted back to master and now devtools::check(vignettes = FALSE, args = '--no-examples') gives this

0 errors ✔ | 2 warnings ✖ | 2 notes ✖

[Kdreval]

To have this tested properly and avoid any confusion, we need to properly set up the github actions just like we had it for the GAMBLR main repo. I imagine everyone's R state is different because of different packages installed from different commits etc but having it configured in actions will ensure the reproducibility. This is a topic for a separate and more wide discussion