morinlab / GAMBLR.viz

Collection of functions to make plots for Genomic Analysis of Mature B-cell Lymphomas in R

https://morinlab.github.io/GAMBLR.viz/

MIT License

0 stars 0 forks source link

Closed Kdreval closed 7 months ago

Kdreval commented 7 months ago

Fixes #43 Also fixes the issue #42

Pull Request Checklists

Important: When opening a pull request, keep only the applicable checklist and delete all other sections.

[X] I ensured not to prepend the functions existing in both GAMBLR.data and GAMBLR.results with <package>::function() syntax.
[X] I ensured not to add GAMBLR.data or GAMBLR.results to the @import section of the documentation

vladimirsouza commented 7 months ago

Since this PR is fixing prettyOncoplot, can you fix splitColumnName parameter documentation? This parameter has no default value.

#' @param splitColumnName Optional argument to indicate which metadata column to split on. Default is set to pathology.

Kdreval commented 7 months ago

Thanks @vladimirsouza , both of the comments are resolved in the latest commit. This is ready for re-review