morinlab / GAMBLR.viz

Collection of functions to make plots for Genomic Analysis of Mature B-cell Lymphomas in R
https://morinlab.github.io/GAMBLR.viz/
MIT License
0 stars 0 forks source link

Hotfixes for various plotting functions #9

Closed mattssca closed 9 months ago

mattssca commented 9 months ago

This PR addresses a few things:

  1. The internal call of assign_cn_to_ssm in comp_report.R calls GAMBLR.results exclusive parameters, causing issues when a non-GSC user runs this function with GAMBLR.data as their only way of retrieving data (i.e calling assign_cnm_to_ssm) (issue #8).
  2. In fancy_propcov_plot, if the user does not provide a data frame with collated results (QC metrics) for comparison values the function inaccurately calls collate_qc_results, this has been updated to properly call collate_results instead.
  3. Lingering issue with heatmap_mutation_frequency_bin.R that wrongly expects id_ease to return a list with metadata and sample IDs as its objects. This has been updated to behave in the expected way.