morinlab / GAMBLR

Set of standardized functions to operate with genomic data
https://morinlab.github.io/GAMBLR/
MIT License
3 stars 2 forks source link

Removed allow_clusted flag, which is not supported by downstream functions #105

Closed ckrushton closed 1 year ago

ckrushton commented 2 years ago

Pull Request Checklists

Important: When opening a pull request, keep only the applicable checklist and delete all other sections.

Checklist for all PRs

Required

get_ssm_by_regions(regions_bed = grch37_ashm_regions)

This can be checked and addressed by running check_functions.pl and responding to the prompts. Test your code after you do this.

Checklist for changes to existing code

Not done, as this change should not affect existing functionality

mattssca commented 2 years ago

This issue was addressed in another PR that was active at the same time as this was created and has been resolved, can you confirm @ckrushton

Thanks,

ckrushton commented 1 year ago

I can confirm this has been fixed. Thanks!


From: Carl-Adam Mattsson @.***> Sent: August 4, 2022 2:49:09 PM To: morinlab/GAMBLR Cc: Christopher Rushton; Mention Subject: Re: [morinlab/GAMBLR] Removed allow_clusted flag, which is not supported by downstream functions (PR #105)

This issue was addressed in another PR that was active at the same time as this was created and has been resolved, can you confirm @ckrushtonhttps://github.com/ckrushton

Thanks,

— Reply to this email directly, view it on GitHubhttps://github.com/morinlab/GAMBLR/pull/105#issuecomment-1205787649, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFKSNJATMECDAJYI5KJXKATVXQY2HANCNFSM5ZYU6BFQ. You are receiving this because you were mentioned.Message ID: @.***>

mattssca commented 1 year ago

This has been resolved in another PR