Closed rdmorin closed 2 years ago
This PR includes an example of a bit of code that should be added to any function that attempts to load a local file. This should help provide a more useful error for users who are running GAMBLR remotely and have either not set up their config (or loaded it properly) or have forgotten to sync the data locally. The relevant chunk is below. Without this code, calling get_manta_sv() on a remote computer will fail with an error about a missing file.
#check for missingness
if(!file.exists(sv_file)){
message("Cannot find file locally. If working remotely, perhaps you forgot to load your config (see below) or sync your files?")
message('Sys.setenv(R_CONFIG_ACTIVE= "remote"')
} #check for missingness
if(!file.exists(sv_file)){
message("Cannot find file locally. If working remotely, perhaps you forgot to load your config (see below) or sync your files?")
message('Sys.setenv(R_CONFIG_ACTIVE= "remote"')
}
I have resolved the merge conflict. Nothing worth mentioning, just some blank lines.
I didn't realize this PR hadn't been merged. I've added to it. Can the new commits be reviewed please?
This reverts commit 22b80a6.# Pull Request Checklists
Important: When opening a pull request, keep only the applicable checklist and delete all other sections.
Checklist for all PRs
Required
[X] I tested the new code for my use case (please provide a reproducible example of how you tested the new functionality)
[X] I ensured all dplyr functions that commonly conflict with other packages are fully qualified.
This can be checked and addressed by running
check_functions.pl
and responding to the prompts. Test your code after you do this.devtools::document()
) and addedNAMESPACE
and all other modified files in the root directory and underman
.Optional but preferred with PRs
Checklist for New Functions
Required
[ ] I documented my function using ROxygen style.)
[ ] All parameters for the function are described in the documentation and the function has a decriptive title.
Example:
import
statment.Example:
Checklist for changes to existing code
[X] I added/removed arguments to a function and updated documentation for all changed/new arguments
[X] I tested the new code for compatability with existing functionality in the Master branch (please provide a reprex of how you tested the original functionality)