Closed rdmorin closed 1 year ago
This addresses some long-standing bugs that may also have been fixed in Adam's branch. If this gets to Master first, we'll need to be careful about not reversing/breaking some of these changes when that branch eventually gets merged. I added a new R script that is meant as a basis for testing that all our function's examples actually work. That code could be used to make some of the new Vignettes.
Trying to deal with inability to resolve conflict
Pull Request Checklists
Important: When opening a pull request, keep only the applicable checklist and delete all other sections.
Checklist for all PRs
Required
[x] I tested the new code for my use case (please provide a reproducible example of how you tested the new functionality)
[x] I ensured all dplyr functions that commonly conflict with other packages are fully qualified.
This can be checked and addressed by running
check_functions.pl
and responding to the prompts. Test your code after you do this.devtools::document()
) and addedNAMESPACE
and all other modified files in the root directory and underman
.Optional but preferred with PRs
Checklist for New Functions
Required
[x] I documented my function using ROxygen style.)
[x] All parameters for the function are described in the documentation and the function has a decriptive title.
Example:
import
statment.Example:
Checklist for changes to existing code
[x] I added/removed arguments to a function and updated documentation for all changed/new arguments
[x] I tested the new code for compatability with existing functionality in the Master branch (please provide a reprex of how you tested the original functionality)