morinlab / GAMBLR

Set of standardized functions to operate with genomic data
https://morinlab.github.io/GAMBLR/
MIT License
3 stars 2 forks source link

removing redundant line from config (tidy_expression_file) #135

Closed mattssca closed 1 year ago

mattssca commented 1 year ago

Pull Request Checklists

Important: When opening a pull request, keep only the applicable checklist and delete all other sections.

Checklist for all PRs

Required

This can be checked and addressed by running check_functions.pl and responding to the prompts. Test your code after you do this.

Optional but preferred with PRs

Checklist for New Functions

Required

Example:

#' Use GISTIC2.0 scores output to reproduce maftools::chromoplot with more flexibility
#'
#' @param scores output file scores.gistic from the run of GISTIC2.0
#' @param genes_to_label optional. Provide a data frame of genes to label (if mutated). The first 3 columns must contain chromosome, start, and end coordinates. Another required column must contain gene names and be named `gene`. (truncated for example)
#' @param cutoff optional. Used to determine which regions to color as aberrant. Must be float in the range [0-1]. (truncated for example)

Example:

#' @return nothing
#' @export
#' @import tidyverse ggrepel

Checklist for changes to existing code

mattssca commented 1 year ago

This PR removes one redundant line from config.yml.

I've checked if any functions in GAMBLR are making use of the tidy_expression_file from the config. The only function that currently calls this from the config is tidy_gene_expression. But I am guessing this will not be an issue, since it was recently decided that this function is to be fully deprecated.

rdmorin commented 1 year ago

Good to know. I don't think you need a PR for this change since it should have no effect on other GAMBLR code. Just leave this change in your branch until the next PR. In the meantime I'll fix the snakefile.

mattssca commented 1 year ago

Got it, I'll remove this PR then. Thanks!