Closed mattssca closed 1 year ago
This PR removes one redundant line from config.yml
.
I've checked if any functions in GAMBLR are making use of the tidy_expression_file
from the config. The only function that currently calls this from the config is tidy_gene_expression
. But I am guessing this will not be an issue, since it was recently decided that this function is to be fully deprecated.
Good to know. I don't think you need a PR for this change since it should have no effect on other GAMBLR code. Just leave this change in your branch until the next PR. In the meantime I'll fix the snakefile.
Got it, I'll remove this PR then. Thanks!
Pull Request Checklists
Important: When opening a pull request, keep only the applicable checklist and delete all other sections.
Checklist for all PRs
Required
[ ] I tested the new code for my use case (please provide a reproducible example of how you tested the new functionality)
[ ] I ensured all dplyr functions that commonly conflict with other packages are fully qualified.
This can be checked and addressed by running
check_functions.pl
and responding to the prompts. Test your code after you do this.devtools::document()
) and addedNAMESPACE
and all other modified files in the root directory and underman
.Optional but preferred with PRs
Checklist for New Functions
Required
[ ] I documented my function using ROxygen style.)
[ ] All parameters for the function are described in the documentation and the function has a decriptive title.
Example:
import
statment.Example:
Checklist for changes to existing code
[ ] I added/removed arguments to a function and updated documentation for all changed/new arguments
[ ] I tested the new code for compatability with existing functionality in the Master branch (please provide a reprex of how you tested the original functionality)