Closed rdmorin closed 1 year ago
Is this a draft that you will update or someone should pick it up and complete? Seems like some functions are work in progress, not sure if this is ready for review
If the SV functionality was merged in PR #148 , is this PR in the works, or will transform into something else? Just wondering if this should be open, converted into a draft, or closed?
I think this was rolled into Adam's PR already
I think this PR should go into master, The PR I started with the new manta SV functions did not have the other updates added to this PR.
I looked over the changes, I think yes not all edits were used in the earlier PR. There are some edits for the new colors and handling of the remote functionality. I think yes it needs to be merged and needs to go to master
Pull Request Checklists
Important: When opening a pull request, keep only the applicable checklist and delete all other sections.
Checklist for all PRs
Required
[ ] I tested the new code for my use case (please provide a reproducible example of how you tested the new functionality)
[ ] I ensured all dplyr functions that commonly conflict with other packages are fully qualified.
This can be checked and addressed by running
check_functions.pl
and responding to the prompts. Test your code after you do this.devtools::document()
) and addedNAMESPACE
and all other modified files in the root directory and underman
.Optional but preferred with PRs
Checklist for New Functions
Required
[ ] I documented my function using ROxygen style.)
[ ] All parameters for the function are described in the documentation and the function has a decriptive title.
Example:
import
statment.Example:
Checklist for changes to existing code
[ ] I added/removed arguments to a function and updated documentation for all changed/new arguments
[ ] I tested the new code for compatability with existing functionality in the Master branch (please provide a reprex of how you tested the original functionality)