morinlab / GAMBLR

Set of standardized functions to operate with genomic data
https://morinlab.github.io/GAMBLR/
MIT License
3 stars 2 forks source link

Add new functions for loading Manta SV from individual files instead of merges #143

Closed rdmorin closed 1 year ago

rdmorin commented 1 year ago

Pull Request Checklists

Important: When opening a pull request, keep only the applicable checklist and delete all other sections.

Checklist for all PRs

Required

This can be checked and addressed by running check_functions.pl and responding to the prompts. Test your code after you do this.

Optional but preferred with PRs

Checklist for New Functions

Required

Example:

#' Use GISTIC2.0 scores output to reproduce maftools::chromoplot with more flexibility
#'
#' @param scores output file scores.gistic from the run of GISTIC2.0
#' @param genes_to_label optional. Provide a data frame of genes to label (if mutated). The first 3 columns must contain chromosome, start, and end coordinates. Another required column must contain gene names and be named `gene`. (truncated for example)
#' @param cutoff optional. Used to determine which regions to color as aberrant. Must be float in the range [0-1]. (truncated for example)

Example:

#' @return nothing
#' @export
#' @import tidyverse ggrepel

Checklist for changes to existing code

Kdreval commented 1 year ago

Is this a draft that you will update or someone should pick it up and complete? Seems like some functions are work in progress, not sure if this is ready for review

Kdreval commented 1 year ago

If the SV functionality was merged in PR #148 , is this PR in the works, or will transform into something else? Just wondering if this should be open, converted into a draft, or closed?

rdmorin commented 1 year ago

I think this was rolled into Adam's PR already

mattssca commented 1 year ago

I think this PR should go into master, The PR I started with the new manta SV functions did not have the other updates added to this PR.

Kdreval commented 1 year ago

I looked over the changes, I think yes not all edits were used in the earlier PR. There are some edits for the new colors and handling of the remote functionality. I think yes it needs to be merged and needs to go to master