Closed Kdreval closed 1 year ago
This is ready for review!
This PR has the master merged and is using the latest update to support most complete SV results when running Chapuy classifier. All other comments were also addressed and marked as resolved. It is ready for merge
Also confirmed the PR approved yesterday has no merge conflicts with this one
This PR now also fixes the bug of randomForest
dependency auto-installation reported in the issue #154
In this PR now I have moved out the functionality of classifications and predictions to it's own designated R package GAMLR.predict. It is ready for review and merge if all looks good. Thanks!
In addition, I also think prettyForestPlot
is using stats
functions (p.adjust) and prettyOncoplot
might also be using the same package (calling the setNames
function). Thoughts?
When doing this update I found the stats
package is one of the r default packages. It is always loaded on startup and is always available without explicitly loading it. When it was added as a dependency, it only created issues with name conflicts etc. Now having this removed makes the GAMBLR easier to load and instead of ~40 warnings on startup, there are only ~ 20. I would think we do not need to revert it back to being explicitly mentioned in NAMESPACE and DESCRIPTION.
Sounds good Kostia, thanks for looking into it!
@rdmorin the merge is blocked even after approval because earlier some changes were requested. Can you please look into this?
Should work now
thanks!!
This PR fixes issues #155 and #154. The autoinstallation has been tested both on Mac and Linux-based systems and the set of command that worked is:
In addition to this, there are updates to the GAMBLR color palette because one of the palettes was having duplicated colors for 2 different genetic subgroups. The
prettyForestplot
has also now functionality to report the number of mutated and unmutated patients in the output of the Fisher test results. There are also some other minor bug fixes inFtestCNV
andadjust_ploidy
functions.All documentation was updated accordingly and the most recent master was merged to ensure no conflicts.