Closed mattssca closed 1 year ago
This PR is now ready for review.
Besides what's described above, this PR also includes the following updates;
Fix for issue #185
Many updates to examples in function docs. The majority of these changes include fixes that allow pkgdown::build_site
to successfully execute all the examples and generate function-specific HTML documents. other updates include writing fully reproducible examples and preventing man/*.Rd
files to be generated for helper/internal functions.
Minor updates to fancy_vignette
, again, allowing for examples to be executed within the pkgdown::build_site
command.
Updates to get_manta_sv
(issue #188). This update includes a change in the logic of this function. For more details, see the described issue. Another parameter was also added to this function (verbose
) to let the user control if read messages should be printed to the console or not. The default behavior is verbose = TRUE
(to honor the existing behavior of this function). All functions that internally call get_manta_sv
has also been updated with respect to the new parameter. The same goes for the vignettes.
Fix for issue #189
This PR is addressing the following items;
Fixing examples that previously had >100 characters per line (causing the examples to be truncated in the PDF manual).
Proposing a fix for reported issue #179.
Adding a "100 characters line" example to the new-function template in the README.
The golden standard function documentation example has been updated to actually reflect the best practices detailed in the previous section (in the README).
New functions added to portal.R. This includes four new functions;
custom_caselist
- Lets the user specify a case list from a set of sample IDs.get_study_info
- Useful for retrieving study-specific identifiers, allowing for easier maintenance of existing studies, updating existing studies, etc.cbioportal_create
- A new helper function that wraps all the other study-specific functions with the same parameters (as defined in this function). Preventing inconsistencies in these identifiers, and also allows for a more straightforward execution for setting up cBioPortal studies. Note, this function is not exported (internal function).setup_expression_data
- This function gathers expression data and prepares it into a format that is accepted by cBioPortal. For more details on how this function operates, see the function documentation.All package documentation has been re-generated, reflecting the latest changes detailed above.
Pull Request Checklists
Important: When opening a pull request, keep only the applicable checklist and delete all other sections.
Checklist for all PRs
Required
[x] I tested the new code for my use case (please provide a reproducible example of how you tested the new functionality)
[x] I ensured all dplyr functions that commonly conflict with other packages are fully qualified.
This can be checked and addressed by running
check_functions.pl
and responding to the prompts. Test your code after you do this.devtools::document()
) and addedNAMESPACE
and all other modified files in the root directory and underman
.Optional but preferred with PRs
Checklist for New Functions
Required
[x] I documented my function using ROxygen style.)
[x] All parameters for the function are described in the documentation and the function has a decriptive title.
Example:
import
statment.Example:
Checklist for changes to existing code
[x] I added/removed arguments to a function and updated documentation for all changed/new arguments
[x] I tested the new code for compatability with existing functionality in the Master branch (please provide a reprex of how you tested the original functionality)