morinlab / GAMBLR

Set of standardized functions to operate with genomic data
https://morinlab.github.io/GAMBLR/
MIT License
3 stars 2 forks source link

GAMBLR Improvements - truncated lines in manual, posted issues, README, new portal.R functions. #184

Closed mattssca closed 1 year ago

mattssca commented 1 year ago

This PR is addressing the following items;

  1. Fixing examples that previously had >100 characters per line (causing the examples to be truncated in the PDF manual).

  2. Proposing a fix for reported issue #179.

  3. Adding a "100 characters line" example to the new-function template in the README.

  4. The golden standard function documentation example has been updated to actually reflect the best practices detailed in the previous section (in the README).

  5. New functions added to portal.R. This includes four new functions;

    • custom_caselist - Lets the user specify a case list from a set of sample IDs.

    • get_study_info - Useful for retrieving study-specific identifiers, allowing for easier maintenance of existing studies, updating existing studies, etc.

    • cbioportal_create - A new helper function that wraps all the other study-specific functions with the same parameters (as defined in this function). Preventing inconsistencies in these identifiers, and also allows for a more straightforward execution for setting up cBioPortal studies. Note, this function is not exported (internal function).

    • setup_expression_data - This function gathers expression data and prepares it into a format that is accepted by cBioPortal. For more details on how this function operates, see the function documentation.

  6. All package documentation has been re-generated, reflecting the latest changes detailed above.

Pull Request Checklists

Important: When opening a pull request, keep only the applicable checklist and delete all other sections.

Checklist for all PRs

Required

This can be checked and addressed by running check_functions.pl and responding to the prompts. Test your code after you do this.

Optional but preferred with PRs

Checklist for New Functions

Required

Example:

#' Use GISTIC2.0 scores output to reproduce maftools::chromoplot with more flexibility
#'
#' @param scores output file scores.gistic from the run of GISTIC2.0
#' @param genes_to_label optional. Provide a data frame of genes to label (if mutated). The first 3 columns must contain chromosome, start, and end coordinates. Another required column must contain gene names and be named `gene`. (truncated for example)
#' @param cutoff optional. Used to determine which regions to color as aberrant. Must be float in the range [0-1]. (truncated for example)

Example:

#' @return nothing
#' @export
#' @import tidyverse ggrepel

Checklist for changes to existing code

mattssca commented 1 year ago

This PR is now ready for review.

Besides what's described above, this PR also includes the following updates;