Closed mattssca closed 2 years ago
The follwoing functions have been updated to load data from the latest (and greatest) deblacklsited mafs and to filter out varaints with low read support:
get_ssm_by_sample get_coding_ssm get_ssm_by_region get_ssm_by_gene (function removed and added "these_genes" parameter to get_ssm_by_sample and get_ssm_by_samples to allow for gene-subsetting). get_coding_ssm_status assign_cn_to_ssm (using updated get_ssm_by_samples)
The updated functions have been tested and also testing other functions that call these functions. See lsited functions bellow for such cases.
get_ssm_by_regions calc_mutation_frequency_sliding_windows get_ashm_count_matrix ashm_multi_rainbow_plot - broken due to get gamblr meta ashm_rainbow_plot annotate_driver_ssm estimate_purity fancy_sv_chrdistplot fancy_snp_chrdistplot fancy_svbar fancy_cnlohbar fancy_vplot
Package documentation has also been regenerated
Thanks for your comments Ryan, here are the two items that needs to be addressed, potentially in another PR?
Pull Request Checklists
Important: When opening a pull request, keep only the applicable checklist and delete all other sections.
Checklist for all PRs
Required
[x] I tested the new code for my use case (please provide a reproducible example of how you tested the new functionality)
[x] I ensured all dplyr functions that commonly conflict with other packages are fully qualified.
This can be checked and addressed by running
check_functions.pl
and responding to the prompts. Test your code after you do this.devtools::document()
) and addedNAMESPACE
and all other modified files in the root directory and underman
.Optional but preferred with PRs
Checklist for New Functions
Required
[x] I documented my function using ROxygen style.)
[x] All parameters for the function are described in the documentation and the function has a decriptive title.
Example:
import
statment.Example:
Checklist for changes to existing code
[x] I added/removed arguments to a function and updated documentation for all changed/new arguments
[ ] I tested the new code for compatability with existing functionality in the Master branch (please provide a reprex of how you tested the original functionality)