morinlab / GAMBLR

Set of standardized functions to operate with genomic data
https://morinlab.github.io/GAMBLR/
MIT License
3 stars 2 forks source link

ashm_multi_rainbow_plot broken? #80

Closed rdmorin closed 2 years ago

rdmorin commented 2 years ago

The example for this function in our vignette produces just a very busy legend.

image
rdmorin commented 2 years ago

I think this is related to ggplot changing the behaviour of scale_X_manual functions, as per:

https://community.rstudio.com/t/scale-colour-manual-does-not-drop-unused-levels/109094/4

rdmorin commented 2 years ago

Confirmed that installing ggplot2 from github resolves this. Not really an ideal solution.

Kdreval commented 2 years ago

I have added a solution for this in #73 that will always subset colors to the keys actually present in the data ✅