moritzjacobs / github-tada

Browse Github issues by reaction
2 stars 1 forks source link

Browse by reaction: no heading, or nothing listed below the heading #2

Closed grahamperrin closed 4 years ago

grahamperrin commented 4 years ago

Home-built Waterfox Classic 56.2.14 on FreeBSD-CURRENT:

image

Firefox Quantum:

image

Tested at:

moritzjacobs commented 4 years ago

Thank you for bringing this to my attention. Is there anything suspicious going on in the error console?

moritzjacobs commented 4 years ago

Also is there another addon that puts the avatars in the reactions? Maybe that messes something up.

grahamperrin commented 4 years ago

another addon that puts the avatars in the reactions?

I tested with a different profile, github-tada alone enabled.

When a page first loaded – maybe after disabling all other extensions – there was an array of rectangles close to the #show_issue part of the page.

After a reload without cache e.g. Control-F5 the rectangles became populated:

image

In retrospect: the non-populated rectangles were remarkable during a previous test, but I chose to not capture a screenshot because (in the absence of any reaction in any rectangle) I assumed that there were a glitch with some other extension.

Reproducible with a simple reload, whilst not signed in, and now I see that each rectangle is clickable:

image

Reloading without the cache is not a reliable workaround for non-population of the rectangles:

image

Eventually:

image

moritzjacobs commented 4 years ago

Thank you for your input, I will see if I can reproduce these issues on the weekend.

moritzjacobs commented 4 years ago

It works in the corresponding Waterfox versions on macOS, I can't really reproduce the problem. Sorry... is it possible to use something like web-ext with WF?

grahamperrin commented 4 years ago

Apologies for the late reply … I've been getting blanks with Firefox 70, the same with 71.0.

With github-tada alone enabled:

image

moritzjacobs commented 4 years ago

I tried both versions on windows and macOS. I can't imagine a reason for this having OS related issues, since it is only javascript. Do you know about limitations for FF on FreeBSD?

grahamperrin commented 4 years ago

Hmm. I had one of these two URLs open in a tab, in very heavily extended Waterfox Classic on FreeBSD-CURRENT, for a long time:

https://github.com/claustromaniac/httpz/issues/37#issuecomment-560488711

https://github.com/claustromaniac/httpz/issues/37

I was preparing to quit the application then noticed, for the first time since I don't know when, an array of reactions in the right-hand column. Stupidly I didn't take a screenshot. After I reloaded the page the array did not reappear.

Postscript

For now, ignore the two URLs above. With the heavily extended Waterfox Classic I certainly had reactions (in the right-hand column) at:

https://github.com/matrix-org/matrix-appservice-irc/issues/208#issuecomment-495803454

– and after reloading the page, the reactions did not reappear.

I tried the same URL with Firefox 71.0 with the extension in isolation, waited a while, the column of reactions did not appear.

Screen recording saved locally.

Weird. I'll keep a closer eye on symptoms over the next few days.

grahamperrin commented 4 years ago

Do you know about limitations for FF on FreeBSD?

It's Tier-3 but I can't imagine a FreeBSD-specific explanation for this issue.

If I look to consoles, should I use the web console alone? Or the browser console?

Focus solely on JavaScript in the console?

moritzjacobs commented 4 years ago

If I look to consoles, should I use the web console alone? Or the browser console?

Maybe both, I'm not sure.

moritzjacobs commented 3 years ago

I just released 2.0.0 which removes react as a dependency, maybe that solves your issue?

=> https://addons.mozilla.org/en-US/firefox/addon/github-tada/