moritzruth / node-enttec-open-dmx-usb

💡 A Node.js library for interacting with the Enttec Open DMX USB Interface
MIT License
14 stars 5 forks source link

Implementing worker_thread #85

Closed ScreamZ closed 1 year ago

ScreamZ commented 1 year ago

As this post mention : https://github.com/serialport/node-serialport/issues/1938#issuecomment-1814364985 I think this could be nice to move the core into a worker_thread to avoid blocking, especially with the uSleep function ?

What do you think, i can help on that ?

moritzruth commented 1 year ago

Hey, I want to keep this library as simple and low-level as possible. Therefore, I think worker_thread support would be out of scope. For the same reason I don’t want animation support (which is inherently opinionated) in this library. Feel free though to create a higher-level library with those features included!