search

moritzsternemann / vue-plausible

Plausible Analytics Vue.js Plugin and NuxtJS Module
MIT License
120 stars 8 forks source link

Use Nuxt runtime config #11

Closed ambroisemaupate closed 2 years ago

ambroisemaupate commented 3 years ago

Fixes #10

This would allow changing Plausible options over different environments (dev, testing, production) using Nuxt runtimeConfig.

moritzsternemann commented 3 years ago

Thanks for the PR! I'm super busy right now, I'll take a look at it towards the end of the week 😄

ambroisemaupate commented 2 years ago

Hi @moritzsternemann

Thanks for your suggestions, PR has been updated.

moritzsternemann commented 2 years ago

Thanks again! I'll publish a new release in a few minutes 🙂

ambroisemaupate commented 2 years ago

@moritzsternemann Thanks,

I just found out that the right override to do was in the plugin, not in the module. Everything which happen in module is in build-time.

Sorry, I'll push a new PR as soon as possible.

moritzsternemann commented 2 years ago

Oh you are totally right, I didn't think of that. Thanks for handling this!