search

moritzvieli / ngx-bootstrap-slider

An Angular Bootstrap Slider, based on seiyria/bootstrap-slider.
MIT License
12 stars 17 forks source link

Angular core and common peer dependency not updated to ng9 #18

Open gesarki opened 4 years ago

gesarki commented 4 years ago

When installing the latest version of ngx-bootstrap-slider I get the following warnings:


npm WARN ngx-bootstrap-slider@1.8.0 requires a peer of @angular/core@^6.0.0-rc.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.
Stargator commented 4 years ago

Thanks @moritzvieli for upgrading to ng 10. I am sensitive to issues like the above for anyone that is still using ng 9 or just migrating to ng 9 as a middle step toward ng 10 or newer.

Would it be reasonable to create a branch that updates the peerDependencies for version 1.8.0 and would create a 1.8.1 version with just that change for ng 9 users?

moritzvieli commented 4 years ago

@Stargator Thanks a lot for the idea! Yes, that makes sense to me! Can you do it?

Stargator commented 4 years ago

@moritzvieli Sure, I should have something in 24 hours

Stargator commented 4 years ago

@moritzvieli I created a branch in my fork: resolve-ng9-peer-dependencies.

The only way I see this working is if you pull down my branch locally or wherever you need it in order to publish version 1.8.1.

It can't be merged into master because it will overwrite the ng10 changes. You could push the branch to this repo and then tag it 1.8.1 before publishing if you want. But I think the major step is pulling the branch down so you can run the steps to publish 1.8.1.

moritzvieli commented 4 years ago

@Stargator Thanks a lot! Sorry, I am really short in time currently. Can I grant you NPM permissions to release it? I can also pull and release it as version 1.8.1. Can you add a note in the readme of the project to use version 1.8.1 for NG9? Thanks a lot!

Stargator commented 4 years ago

@moritzvieli Sure, you can give me contributor and npm permission and I can tag it and publish. Let me know if there's any specific steps you want to ensure I do

moritzvieli commented 4 years ago

@Stargator Cool! What's your username on NPM? No steps beside the ones documented in the README.

Stargator commented 4 years ago

@moritzvieli it's stargator

Stargator commented 3 years ago

@moritzvieli I can verify I have access on npmjs. Sorry for the delay. I spilled water on my laptop a few days after Sep 19 and it took me awhile to get a new one.

Stargator commented 3 years ago

@moritzvieli 1.8.1 has been published with the peer-dependency update