Add the ability for a Drop to have an action.

morizotter / SwiftyDrop

Lightweight dropdown message bar in Swift. It's simple and beautiful.

MIT License

683 stars 74 forks source link

Add the ability for a Drop to have an action. #30

Closed nickcharlton closed 8 years ago

nickcharlton commented 8 years ago

This adds the ability for a Drop to execute a closure when tapped. In addition to the action completion block, it also has a userInfo dictionary which can allow a user to pass along data to work with when the closure executes, such as when using a Drop to respond to a Push Notification.

morizotter commented 8 years ago

Thanks for your pull request! I'll merge it! I have a few that I want to change. I'll let you know the change points later;)

morizotter commented 8 years ago

I Added changes to your pr:) Main reason is for simplicity. Changes are below:

https://github.com/morizotter/SwiftyDrop/commit/a1ee745e46e18367f29afc91e24b08ac9ab98a6e

Changes

Simpify variables.
Remove userInfo because closure captures the passed values.
Add typealias to drop action.
Use optional chaining for simplicity.

I hope you are pleased with these changes:)

@nickcharlton

nickcharlton commented 8 years ago

Wonderful, thank you!

And yes, completely happy with your changes!