morko / haxroomie

Haxroomie is an API and CLI to run headless HaxBall rooms without GUI.
17 stars 14 forks source link

Wrong link to default config file #13

Closed saviola777 closed 5 years ago

saviola777 commented 5 years ago

The link to the default config gives a 404 error. You could also link to

https://github.com/saviola777/haxball-headless-manager/blob/master/config/default.js

at this point, since my default config is "haxroomie-compatible" I believe.

morko commented 5 years ago

Fixed in 64364a26cec0f6cca21eb0beb0d4044fd3dd56c0. Changed the file so much that I can not link your file.

saviola777 commented 5 years ago

I see, how about using some deep merging of objects, like this or lodash.merge or jQuery.extend? Would be cleaner, and HHM pulls in jQuery anyway (originally for DOM manipulation, now only for these QoL things :D Maybe I should reconsider that).