morkro
commented
4 years ago Oh wow, this is great! I like that you already implemented a version of this for v1. Is there a way for me to check out your implementation and see the feature in action? Happy to move this discussion to another channel :)
Can you give your opinion about this feature? I can (help) implement this, but would like some advise :)
Happy to have collaborators on this! From a pure feature perspective I'd imagine it like this:
- Every user has a
defaulthousehold where all existing plants will be part of - A household is essentially just a collection of plants, that is maintained separately to the list
- In Firebase I'd add a new collection
householdswith aname,guid,members, and list of plant ids that belong to that household. membersis just a list of Firebaseguids- To invite someone to a household you either a) invite them via email or b) share household via unique id
- Users can be guests or editors
Open questions would be
- How to handle permission rules in Firebase?
- How to handle email invitations
- Share via unique ID would essentially be public for all and you need to know the ID to see it
- What would the design for this feature look like?
But this needs a thorough discussion and look at the feature. The UX is very important as well. I haven't thought this through at all yet, as it has just been living in my backlog until now.
matthijsthoolen
Hi Morkro!
The new v2 option is looking really great! Thanks for all the effort.
I would really love to be able to use the new design and the new features.
For v1 I have created some small additions for my own forked project, they were mostly designed to be only used by me because you were working on the v2 version already. So it was a good opportunity to get up and running with vue.js and the project.
One of the things I have added was an option to share your plants with others (with some small changes that they were not allowed to remove plants or tags). To 'connect' with the plants of another person I have added a unique code you have to enter to join their household.
But this is not something I want to implement in this version, mainly because it might not be that secure :)
I have a few ideas how this can be implemented:
1) Dont make the user the first collection (dont know what the correct naming is), but create a household instead (might be hard to make a migration for exiting data...). A user can than be connected to a household, an owner can be set which in turn can 'open' the household and accept or deny new members.
2) Keep the user as the main collection, and use the user document as a 'joinable entity'. This might work (I did it in my PoC), but it might be a bit of a hackish way).
Can you give your opinion about this feature? I can (help) implement this, but would like some advise :)