search

morkt / GARbro

Visual Novels resource browser
MIT License
2.34k stars 247 forks source link

About file name encoding of Artemis engine resource archive. #162

Closed haniwa55 closed 6 years ago

haniwa55 commented 6 years ago

I think that script engines compatible with iOS and Android often use UTF8 for file name encoding. The pfs archive of "Real Eroge Situation! Hx 3" (https://vndb.org/v21894) is Version 6. However, the file name encoding is UTF8. The OpenPf() method of Artemis/ArcPFS.cs is coding as follows.

 var encoding = version >= 8 ? System.Text.Encoding.UTF8 : Encodings.cp932;

I think that there are both cp932 and UTF8 in the Version 6 archive. If file name is incorrect, GARbro can not understand the resource exactly as shown in the figure below. The reason is that GARbro can not get the correct filename extension. artemis

GARbro can choose the encoding when browsing text files. So I think that these problems can be solved if the user can choose the encoding of the file name. artemis2

I think that Artemis engine pfs archive Version 8 is the current main stream. So it is possible that this game title is an irregular pfs archive Version 6. So it may not be necessary to extend GARbro only for this game title. However, there is a possibility that such irregular game titles will be released even after the future pfs archive Version 8. I'd appreciate if you will consider this issue at your free time.

haniwa55 commented 6 years ago

encoding Thank you very much for update despite being so busy. Огромное спасибо!