search

morlandi / django-ajax-datatable

A Django app which provides the integration of a Django project with the jQuery Javascript library DataTables.net
MIT License
204 stars 64 forks source link

Export #82

Open jpuerto-psc opened 2 years ago

jpuerto-psc commented 2 years ago

Added functionality to export tables to CSV.

jpuerto-psc commented 1 year ago

@morlandi - pinging to get review/thoughts

morlandi commented 1 year ago

Hello @jpuerto-psc .. thank you for contributing. I noticed your PR some time ago, but didn't find the time to dig into it, yet. I totally understand the need to export from the table preserving user's choices (filters in first place) and agree on adding this functionality to the app.

My first impression is that your proposal could be improved by removing most duplicated code (both js side then Python side). I'm sure I already did it in a project, and wish to recover that code for comparison

bradsolves commented 1 year ago

+1 would love to see this feature implemented! Thank you both for your efforts here