morningconsult / docker-credential-vault-login

Automatically gets docker credentials from Hashicorp Vault
Apache License 2.0
77 stars 11 forks source link

refactor: inline version package #129

Closed rliebz closed 10 months ago

rliebz commented 10 months ago

On macOS, this project runs into a lot of trouble with both VERSION and version existing in the same directory. Basically, only one or the other is able to exist at any point in time, so it's virtually impossible to get a clean git setup.

The good news is the version package only really existed to house a few constants, so moving those to the main package was relatively straightforward. It did require changing the build flags in the two places where they are defined, but that didn't cause trouble.

There are a lot more "modernization" opportunities here, but my goal for the scope of this PR is just to make it possible to work on the project on macOS without git issues.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.