morningconsult / docker-credential-vault-login

Automatically gets docker credentials from Hashicorp Vault
Apache License 2.0
77 stars 11 forks source link

Support v2 KV secret engine #15

Closed optiz0r closed 5 years ago

optiz0r commented 5 years ago

Feature Description

The KV version 2 secret engine in recent versions of vault structures the paths slightly differently. A secret is read from ${mountpoint}/data/${path} rather than ${mountpoint}/${path}. And the resulting response has the expected username and password keys nested under a top-level data key.

Use Case(s)

The version 2 KV engine handles versioned secrets, allowing rollback to previous state.

dbellinghoven commented 5 years ago

@sarkis addressed this issue in https://github.com/morningconsult/docker-credential-vault-login/pull/23. Closing.