Add support for kv secrets engine v2

morningconsult / docker-credential-vault-login

Automatically gets docker credentials from Hashicorp Vault

Apache License 2.0

77 stars 11 forks source link

Add support for kv secrets engine v2 #23

Closed sarkis closed 5 years ago

sarkis commented 5 years ago

Issue #, if available: GH-15

Description of changes: This PR modifies GetCredentials with the changes needed to get credentials from KV v2 secrets engine mount. The version of the mount is determined by looking for the metadata key in the response which will only exist if the secret being returned is from the KV v2 secrets engine.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sarkis commented 5 years ago

Hi @dbellinghoven, is there some way to find out what failed in the Concourse CI build?

alexdulin commented 5 years ago

@sarkis The CI job for merge requests is now public, sorry about that. You can see the logs here.

Looks like your MR needs a go fmt