search

morningconsult / docker-credential-vault-login

Automatically gets docker credentials from Hashicorp Vault
Apache License 2.0
77 stars 11 forks source link

Parse the registry hostnames #25

Closed sarkis closed 5 years ago

sarkis commented 5 years ago

Issue #, if available: GH-21

Description of changes: This PR will parse the registry url and extract hostname and optionally port (if it is passed).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sarkis commented 5 years ago

Looks great, thanks again!

Thanks for such a great project!

As a note to myself, I'll have to make the registry name in the secrets table lowercase when it's created, and make registry lowercase when GetPath is called to avoid any issues related to case sensitivity.

Ah good catch - I'd be willing to work on this as an enhancement. I'll see if I can get to it soon, if you are OK with that.

dbellinghoven commented 5 years ago

Thanks for such a great project!

It's our pleasure! Glad to see others find it useful.

I'll see if I can get to it soon, if you are OK with that.

By all means! We really appreciate all the contributions you've made thus far and welcome all future contributions as well.