search

moroen / IKEA-Tradfri-plugin

A Python plugin for Domoticz to controll IKEA Gateway
68 stars 23 forks source link

Possibility of setting color for groups added. #78

Closed kjlisby closed 4 years ago

kjlisby commented 5 years ago

I have issued a corresponding pull request to pytradfri.

moroen commented 5 years ago

Nice!

As soon as pytradfri is updated, and a version that supports this is available with pip, I´ll merge this!

Regards, M

kjlisby commented 4 years ago

pytradfri is updated now on pypi

moroen commented 4 years ago

There's no check to see if the group (or at least) one of the bulbs in the group supports RGB or just White Balance. This breaks the consistency with the rest, as only devices that supports RGB gets a RGB-selector, devices that support only WB gets the WB-selector.

I'm currently planning to obsolete this version of the plugin, in favor of a plugin that uses aiocoap instead of depending on coap-client, so I'm not sure if it's worth the hassle to implement this kind of checking in this version. I'll accept this pull-request as is, and thanks to your contribution to pytradfri, it's possible to add this kind of checking in the new version!