search

morosebose / tour_de_world

Displays information about the countries of the world.
Mozilla Public License 2.0
0 stars 1 forks source link

Surajit #14

Closed morosebose closed 1 year ago

morosebose commented 1 year ago

Hiya James! I loved your changes to the windows! Moving the total number of countries / area or population to below the listbox makes so much sense. Having the scrollbar show up only for the multiple selection of countries is also a great idea! The windows look much nicer now in size as well.

I cleaned up the code around the listbox and scrollbar a bit. I also made some style changes more because I'm OCD about that sort of thing (putting spaces around the = operator, for example), but the only real change is the cleanup around the listbox code. I also found the text on the "Visit on Google Maps" button a tad too small so bumped it up by 1pt but if you think it's too big we can change it back in a subsequent commit.

jcmkang commented 1 year ago

Hey! quickly saw the changes. going into work now. I will look at the new request in detail when I get home after work. seems like you cleaned up the if multi: block. thank you!

I probably won't get to it till tonight or tmrw morning.

Have a beautiful weekend! 👍🏻