search

moroshko / react-autosuggest

WAI-ARIA compliant React autosuggest component
http://react-autosuggest.js.org
MIT License
5.97k stars 586 forks source link

Make react-autosuggest preact compatible #749

Open jindra12 opened 4 years ago

jindra12 commented 4 years ago

Hello everyone,

I wanted to thank the author for creating this amazing package. I have however noticed that thanks to autowhatever, this package is not compatible with preact, when used in Internet Explorer.

As Internet Explorer is still somewhat used, I want to create a pull request that will make autowhatever use event.keyCode instead of event.key. This will make it possible for IE + preact combo to work without error.

What do you think?

aberezkin commented 4 years ago

Hi! Can you please provide an example of an error and maybe reproduction repository?

And if you already know how to fix it fell free to file a pull request!

jindra12 commented 4 years ago

@aberezkin Sadly, I'm currently on a linux system so I can't. But I already know how to fix it since I encountered it at work. Creating pull request right now.

jindra12 commented 4 years ago

@aberezkin I'm fairly new to this, so I'm not sure what I should do right now - can you invite me to collab on this repository so I can create a branch? I'm sorry if this is a silly question, but I'm unable to create branches in this repo.

aberezkin commented 4 years ago

@jindra12, you can fork it, create a branch in your own repo and then make a pull request in this repo. https://help.github.com/en/github/getting-started-with-github/fork-a-repo

jindra12 commented 4 years ago

@aberezkin Thank you so much! Here is the pull request. https://github.com/moroshko/react-autosuggest/pull/750