search

morpheus65535 / bazarr

Bazarr is a companion application to Sonarr and Radarr. It manages and downloads subtitles based on your requirements. You define your preferences by TV show or movie and Bazarr takes care of everything for you.
https://www.bazarr.media
GNU General Public License v3.0
2.86k stars 223 forks source link

Search for wanted Movies Subtitles fails on sync step (V0.9) #1033

Closed Magikarplvl4 closed 4 years ago

Magikarplvl4 commented 4 years ago

Describe the bug Execute movie subtitles search, it will crash after a minut of 3 a 4 it will crash.

To Reproduce Steps to reproduce the behavior: 1.Execute movie subtitles search

  1. Wait
  2. Execute failed

Expected behavior Finishing without an error ;)

Screenshots

Software (please complete the following information):

Additional context Debug logs: bazarr.log

morpheus65535 commented 4 years ago

This is an issue with this subtitles (/movies/Films 1080P/Promare (2019)/Promare.2019.REPACK.1080p.BluRay.FLAC.5.1.x265-Meakes.mkv-xpost.en.srt) and ffsubsync:

raise SRTParseError(expected_start, actual_start, unmatched_content)srt.SRTParseError: Expected contiguous start of match or end of input at char 0, but started at char 92 (unmatched content: '00:00:00,000 --> 00:00:00,000\nsubtitles edited and timed by sunshinesubs @ subscene & tumblr')

Did you try to blacklist this subtitles and get another one?

@smacke is this a known issue or could you give some tips to fix the issue?

Magikarplvl4 commented 4 years ago

Hi @morpheus65535,

The subtitle wasn't on my history movies list, so im unable to blacklist it. For debug purpose, here is the subtitle that triggering the error subtitle.zip

As a workaround, im ignoring the movie with setting manually the wanted subtitle to non ;)

morpheus65535 commented 4 years ago

I've improved the exception management when trying to sync a subtitles. If something goes wrong, only the sync should fail and the rest of the process should go as planned (including history logging). Can you test it please?

smacke commented 4 years ago

@morpheus65535 the original issue should only occur if the subtitle is malformed somehow, in which case the srt package throws an error.

morpheus65535 commented 4 years ago

@morpheus65535 the original issue should only occur if the subtitle is malformed somehow, in which case the srt package throws an error.

Thanks mate for the feedback! Really appreciated :-)

Magikarplvl4 commented 4 years ago

Still testing the fix, a lot of providers are down at the moment, so im unable to test it right now :(

Magikarplvl4 commented 4 years ago

Its fixed, i see a nice error message in the logs and the search continu's.

Thanks @morpheus65535, you can this one

morpheus65535 commented 4 years ago

Thanks!