Closed alneven closed 1 year ago
two extra screenshots
@Belphemur could you take a look at this issue please? Seems strange to have a match on series and year since it's not the good one at all.
Definitely a problem.
Currently, I don't do exact match with the series name.
Addicted doesn't store the year of the series either (sometimes they do in the title when there are conflicts).
Addicted has a tendency of merging languages (as you can see on the screenshot), adding UK to weird place and not respecting tvdb naming scheme.
I need to think of a good way to fix this. I technically could get the dates from Tvdb for matching shows then return that to the provider and use it as part of the scoring.
@Belphemur does the addic7ed provider (or yours of course) return the tvdb_id? We can compare it and assume year is a match if tvdb_id do match, right?
Addicted provider doesn't have the tvdb_id. However, for the shows I match with TvDB I could return it and use it for the parsing of the returned show in the gestdown provider. That'd be quite easy to add.
I'll see if I have time later today to do that.
Logic to be used for the gestdown provider in bazarr.
@Belphemur thanks!
If tvdb_id match, series/movie title and year should match. If tvdb_id is found, return [].
I just realized, it's a little more work on my side. I don't have the tvdb_id but the tmdb_id (since tvdb had ... shitty pricing for accessing their API --").
I'll implement track.tv to get the tvdb_id for the shows and return that.
I'll update this issue and use it for the modification to the gestdown provider.
(also unrelated @morpheus65535 the gestdown service is now getting around 30 Millions daily requests ^^, thanks to Cloudflare to cache around 70% of all those requests).
@Belphemur why not get the tvdb_id for each series using this?
Hoooo, I didn't see they had that endpoint, thanks ! That going to make things quite easy :D
I have a working version, but Addicted being Addicted, I have 270 shows that have duplicate matching for TVDB_ID. The issue is, Addicted don't always put the year for a show, actually, they only do it in case of dupe.
I already have an algorithm in mind to fix most cases.
@Belphemur in that case maybe you can match by number of seasons or number of episodes? Hope you get a solution to that issue!
@morpheus65535 Tried that, still lots of dupe (same amount actually, too many show stop at one season or more likely, old show stopped at 1 season. Remake just started so ... 1 season).
Number of episodes might be too restrictive. Addicted doesn't always have the full list of episode right away.
What I need to do is group the dupe together, find those that have the date set on them like Accused (2023)
vs Accused
and search for tv show for Accused
and discard the one that started in 2023 to get the tvdb_id of Accused
. (Most of the time it'd be the next show in the list from the search of TMDB).
@Belphemur ok understood. Your strategy seems to be the best you can do with what you have available.
@morpheus65535 Everything is in place, I still have dupe, but real dupe where the same show is on Addicted but with different name.
I've updated the provider in #2078 to use the tvdb_id.
@Belphemur thanks my friend, it's really appreciated!
@alneven your issue should be fixed in upcoming beta. Can you test and report quickly please?
@alneven your issue should be fixed in upcoming beta. Can you test and report quickly please?
uh, @morpheus65535 I will check how can I do it, I'm currently on latest docker container, I guess I should to switch to tag "develop"
@alneven yes if you're using LSIO images, switch to linuxserver/bazarr:development
Now I get “no result” Its working.
Describe the bug hello there, as discussed in Discord I have the UK show Better in my downloads and wanted to download ENG subtitles for it. The show has already 3 aired EPs. So today I turned the download of ENG sub in bazarr on and got very fast all the 3 episode matching sub downloaded. This was a bit odd for me, therefore I run the manuall search and checked the release group was LOL (old scene group, not even active in the UK). So I clicked the button to download the sub on my device and saw it is for Better Call Saul. Then I asked for some advise on Discord and we came to the fact that this shouldn’t be the case even the tv show Better not yet exists on addic7ed (!)
To Reproduce Steps to reproduce the behavior:
Expected behavior Message: no subtitles found
Screenshots
Software (please complete the following information):
Additional context