search

morpheus65535 / bazarr

Bazarr is a companion application to Sonarr and Radarr. It manages and downloads subtitles based on your requirements. You define your preferences by TV show or movie and Bazarr takes care of everything for you.
https://www.bazarr.media
GNU General Public License v3.0
2.87k stars 223 forks source link

Chinese subtitle downloading issue for the provider "Assrt" #2761

Open xuanguang opened 3 hours ago

xuanguang commented 3 hours ago

Describe the bug Lots of Chinese subtitles cannot be downloaded, but they exist in Assrt (http://assrt.net).

In my case, for example, the TV show "All Creatures Great & Small (2020)", S05E01, two subtitles can be found from the Assrt website, but none of them can be downloaded. From the log I can see, BAZARR Skipping <AssrtSubtitle: 不知道 [<Language: alpha3=zho>]>, because it doesn't match our series/episode| but in fact, they are the right ones. I tried the API (which was copied from the Bazarr log) from my web browser, and found the response as the figure below. It seems the wrong key work is used: the "videoname" is not the correct name key, while the "_nativename" is. image

Of course not only this TV show in Assrt, but lots of, I found that they have such similar issues.

To Reproduce Steps to reproduce the behavior:

  1. Add "All Creatures Great & Small (2020)" into "Series"
  2. Configure the downloading language as "Chinese".
  3. Try to download (automatically or manually) the subtitle of S05E01, as the figure below. You can find that no subtitle will be downloaded. image
  4. But the right subtitles exist on the Assrt website (http://assrt.net), as shown below. image

Expected behavior The right subtitles are matched and downloaded correctly.

Screenshots Screenshots are attached above.

Software (please complete the following information):

Additional context From the Bazarr log, I saw the issue should come from the API response keyword, but not sure, please check and help, thanks!

xuanguang commented 3 hours ago

Maybe there should be some check logics here.

I also found that sometimes the key "videoname" is configured correctly. But in Chinese, the meaning of the word "不知道" in my first example is "unknown", which is the value of "videoname" in the example case. So for such cases, if the "videoname" is "不知道"(which means "unknown"), or other meaningless value, we can try the "_nativename" again. Thanks.