morpheus65535
commented
4 years ago Did you tried dev branch?
Closed jpf4e closed 4 years ago
morpheus65535
commented
4 years ago Did you tried dev branch?
jpf4e
commented
4 years ago Yes, just tried it and it fails with the TypeError.
GermanG
commented
4 years ago I see two different issues here
For 1, I'd like to have the log line having the text with
BAZARR is using these video object propertiesI'll try to reproduce it with that info.
For 2, in series is seemed to be easy if I try to match the season and episode, but then the issue is how that info can be: s01e01, 1x1, 101, etc. For movies can be worst, if we have for different releases in the same archive, that'll be more difficult to figure out.
jpf4e
commented
4 years ago The log you asked for:
22/02/2020 22:14:58|DEBUG |root |BAZARR is using these video object properties: {'name': '/home/joao/Series/Shooter/Season 2/Shooter.S02E04.720p.HDTV.x264-SVA[eztv].mkv', 'format': 'HDTV', 'release_group': 'SVA', 'resolution': '720p', 'video_codec': 'h264', 'audio_codec': 'AC3', 'imdb_id': None, 'hashes': {'opensubtitles': '7713ccbf259dd615'}, 'size': 1011505684, 'subtitle_languages': set(), 'original_name': 'Shooter.S02E04.720p.HDTV.x264-SVA[eztv].mkv', 'plexapi_metadata': {}, 'hints': {'title': 'Shooter', 'type': 'episode', 'single_value': True, 'expected_title': ['Shooter']}, 'audio_languages': set(), 'external_subtitle_languages': set(), 'series': 'Shooter', 'season': 2, 'episode': 4, 'title': 'The Dark End of the Street', 'year': 2016, 'original_series': True, 'tvdb_id': None, 'series_tvdb_id': 311900, 'series_imdb_id': None, 'alternative_series': [], 'used_scene_name': True, 'original_path': '/home/joao/Series/Shooter/Season 2/Shooter.S02E04.720p.HDTV.x264-SVA[eztv].mkv', 'fps': 23.976}|
Note: I was using two providers: legendasdivx which failed and opensubtitles (which retrieved good subtitles).
GermanG
commented
4 years ago @JpF4E Regretfully I cannot reproduce the error. Silly question, do you have unrar installed? (It's mandatory for the python unrar module). @morpheus65535 I've made a short script to test that provider, I think it can fit any provider. I know everything is hardcoded ;) EDIT: gist https://gist.github.com/GermanG/b6e24ceb845565f7557ace26af62e197
jpf4e
commented
4 years ago Okay, I didn't have unrar installed. And that was the problem.
I setup a CentOS 8 server some time ago and probably never needed it before.
The provider is now fine to me. I understand there are problems with the score calculation when many subs come in the same archive. Actually, it is downloading the wrong subtitle. It is not just a score problem.
GermanG
commented
4 years ago @JpF4E did you check with the lastest dev? I've made a PR today that might fix the issue (not scoring yet)
jpf4e
commented
4 years ago I tried your latest change in development: It now downloads the correct subtitle and the file is indeed in the disk and correctly named. However in the bazarr interface it still displays as missing, like it isn't detecting the new file. Did it happen to you? Or maybe I'm doing something wrong.
GermanG
commented
4 years ago And you're not looking for Shooter.S02E04? Maybe is not the version you want, can you try my repo? https://github.com/GermanG/bazarr/tree/legendasdivx (it's the legendasdivx branch) I've put scoring there.
jpf4e
commented
4 years ago I cloned your repo and now I can't find the provider at all:
jpf4e
commented
4 years ago And you're not looking for Shooter.S02E04? Maybe is not the version you want, can you try my repo? https://github.com/GermanG/bazarr/tree/legendasdivx (it's the legendasdivx branch) I've put scoring there.
I was looking for that episode. In the Missing section I clicked to search the subtitles. The loading phased out but the episode remained in the missing section as if the subtitle was still not present (or no results returned) but it downloaded the subtitles correctly. It's just the interface that didn't detect it. The correct srt was present alongside the mkv.
GermanG
commented
4 years ago I cloned your repo and now I can't find the provider at all:
Looks like you're in the master branch (I'm following development branch directly from morpheus65535)
git checkout legendasdivx
GermanG
commented
4 years ago And you're not looking for Shooter.S02E04? Maybe is not the version you want, can you try my repo? https://github.com/GermanG/bazarr/tree/legendasdivx (it's the legendasdivx branch) I've put scoring there.
I was looking for that episode. In the Missing section I clicked to search the subtitles. The loading phased out but the episode remained in the missing section as if the subtitle was still not present (or no results returned) but it downloaded the subtitles correctly. It's just the interface that didn't detect it. The correct srt was present alongside the mkv.
This behaviour happens to me when I mess up with the provider and something breaks, surprisingly your log doesn't show anything.
jpf4e
commented
4 years ago I cloned your repo and now I can't find the provider at all:
Looks like you're in the master branch (I'm following development branch directly from morpheus65535)
git checkout legendasdivx
Ahh you're right, damn you git.
Okay, with your version it worked fine. I cleared my data folder though. Maybe there could be some kind of inconsistency. I'm going to try the development branch again with no data folder and then try with my old one.
Something I noticed, is that this time the guess was made against all SRT files inside the rar. In the Log I provided above, it finished whe it reached S02E04.
jpf4e
commented
4 years ago Okay, I did both tests that I mentioned and it worked fine. It probably was some kind of inconsistency that I created.
Feel free to close the issue when you merge.
morpheus65535
commented
4 years ago Merged. I close this one. Thanks @GermanG !
Describe the bug When downloading a subtitle for the series "Shooter", episode S02E04 the provider fails with the error: "TypeError. Exception info: 'expected str, bytes or os.PathLike object, not NoneType'".
For this episode the provider downloads a Rar file with the subtitles for all the episodes of the season and it fails opening a file from the inside of the Rar file. See "Additional Context" for logs.
To Reproduce Steps to reproduce the behavior:
Expected behavior It should not have given the error.
Screenshots No need.
Software (please complete the following information):
Additional context Relevant logs: