search

morpheus65535 / oscarr

Oscarr is a dashboard application for users of Plex, Emby, Sonarr, Radarr and Bazarr. It gives you and overview of your media management software.
GNU General Public License v3.0
57 stars 12 forks source link

Hostname and/or ip #2

Closed jeliasson closed 5 years ago

jeliasson commented 5 years ago

I noticed that there is a validation for Listening IP address to make sure this is an IP-address of services like Sonarr, Radarr etc. What's the reasoning behind this? In my Docker setup, I don't necessarily know the ip-address of said service, just the service name which is resolvable in Docker.

As it's not really binding to any ip-address, I suggest renaming Listening IP address (and it's underlying variables and validation) to Host or similar.

Cheers!

morpheus65535 commented 5 years ago

If you are talking about the Bazarr setting, python need to bind to an IP address. Use 0.0.0.0 if you want to bind to any address. For Sonarr and Radarr, this setting is already name Hostname or IP address.

jeliasson commented 5 years ago

Why do Bazarr need to be binded to an ip address? (Haven't digged in the code) When I tried, I was having problem with Plex and Radarr which seems to be validating to an ip-adress.

Plex One

morpheus65535 commented 5 years ago

Ok, sorry, I was thinking you were asking about Bazarr. :-)

This could be relaxed like it were in Bazarr. Thanks for the suggestion.

jeliasson commented 5 years ago

Did not realized that you maintained both. Kudos! 👍

morpheus65535 commented 5 years ago

Fixed in bf9e39e0f5376c6bd03d23178e817912b0d35fac