Post cantina

[MerlinEgalite]

Contains:

• 100

  • Missing interface for AdaptiveCurveIrm

• 103

  • Overly complex use of deployment immutables over constants

• 107

  • Incorrect naming of MathLib.wMulDown & MathLib.wDivDown regarding their round-to-zero behavior in the integer space (#127)

• 108

  • Incorrect documentation of the behavior of the speed between updates of the stateful IRM (#139)

• 105

  • Insanely large maximum APR & APY calculated by the stateful IRM, potentially leading to large share deflation & slippage (#450)
  • Misleading comments and definitions of constants

• 116

  • Removes a useless import

• 114

  • Renames To0 ToZero

• 117

  • Add missing natspec comment

[MerlinEgalite]

@Rubilmax @Jean-Grimal can you create a PR to resolve conflicts please?

EDIT: nvm just saw @MathisGD's PR

[Rubilmax]

@Rubilmax @Jean-Grimal can you create a PR to resolve conflicts please?

111 is what you're looking for

[MerlinEgalite]

already edited my comment haha

[StErMi]

I think that you can remove using MorphoMathLib for uint256; from AdaptiveCurveIrm

https://github.com/morpho-org/morpho-blue-irm/pull/106/files#diff-a05758836d08a2a735bb478d93a10a8b2dacd40fb639d4c59104a6169552df79R23

The only op from MorphoMathLib (math lib from morpho blue) is

        int256 utilization = int256(
            market.totalSupplyAssets > 0 ? market.totalBorrowAssets.wDivDown(market.totalSupplyAssets) : 0
        );

But both of them are uint128 and not uint256.

At this point, I'm wondering what are the consequences if one of the types (external to the IRM) changes, and you can't apply anymore the MathLib. Does it revert directly?

[StErMi]

Looks good