morpho-org / morpho-blue-irm

Morpho Blue Interest Rate Models
https://morpho.org
MIT License
26 stars 17 forks source link

refactor(math): revert to int256 #60

Closed Rubilmax closed 11 months ago

Rubilmax commented 11 months ago

Fixes https://github.com/morpho-labs/morpho-blue-irm/pull/54#discussion_r1383056630

Rubilmax commented 11 months ago

I understand now that it's inconsistent with what I could have suggested: having constants typed the most restrictive (uint256) to make sure they are not negative. But in the end, this stricter typing doesn't allow to save checks so there's no real benefit of using it and it's even easier for us to type them int256 because we use them in int256 contexts

Rubilmax commented 11 months ago

I let you handle it @MathisGD