morpho-org / morpho-blue-oracles

Morpho Blue Oracles
https://morpho.org
Other
35 stars 28 forks source link

Discuss stale period #11

Closed MerlinEgalite closed 1 year ago

MerlinEgalite commented 1 year ago

As a reference:

On my side I'd be in favor of implementing a stale period check of 36 hours or 48 hours. This is a safe margin I think. We can safely say that after this period the price feed is stale

MathisGD commented 1 year ago

I don't think that the check should be implemented, because:

Rubilmax commented 1 year ago

it is very low probability that Chainlink on purpose shuts down a feed without making it revert

is this claim backed by a discussion with their team? (in any case, I don't think we should consider whether they are going to revert or silently make it stale)

MerlinEgalite commented 1 year ago

We should at least add a comment IMO