search

morpho-org / morpho-blue-oracles

Morpho Blue Oracles
https://morpho.org
Other
35 stars 28 forks source link

Chainlink ERC4626: allow to pass the vault decimals directly #19

Closed QGarchery closed 1 year ago

QGarchery commented 1 year ago

To fix that https://github.com/morpho-labs/morpho-blue-oracles/pull/7#discussion_r1353496359

QGarchery commented 1 year ago

I'm not a fan of sample tbh..

Why not ? I feel like it fits pretty well: we take a sample, price it, scale it down to get the generic price

MerlinEgalite commented 1 year ago

I'm not a fan of sample tbh..

Why not ? I feel like it fits pretty well: we take a sample, price it, scale it down to get the generic price

I have the feeling that a sample is something that can change from the definition (else why taking a sample) while here study the evaluate the value of the same amount of shares each time. So to me it feels more like a reference.

I'm approving as I don't think it's a big deal