morpho-org / morpho-blue-oracles

Morpho Blue Oracles
https://morpho.org
Other
33 stars 27 forks source link

Use minimal CL interface #71

Closed MerlinEgalite closed 8 months ago

MerlinEgalite commented 8 months ago

Naming can be changed if needed

Rubilmax commented 8 months ago

Why removing description if it doesn't revert ?

Agree that there is an inconsistency here: we could keep description in the contract and not in the interface, in the same way ST_ETH is public and not in the interface

I believe the rationale is: we were forced to add it back when we wanted to comply with Chainlink's interface, but it doesn't make sense for us to have it because we don't want to expose a description string from our adapter The only reason to keep it would be to be "more compliant" with Chainlink, but we don't care