Should `expectedAssets` precise the rounding

morpho-org / morpho-blue

🟦 Morpho Blue Protocol

https://morpho.org

Other

146 stars 53 forks source link

Should `expectedAssets` precise the rounding #660

Closed MathisGD closed 10 months ago

MathisGD commented 11 months ago

these functions round in a certain way (the "natural way"), but don't say in their name what they are doing. It probably caused an issue in mm. Should we rename them ?

https://github.com/morpho-org/morpho-blue/blob/55d2d99304fb3fb930c688462ae2ccabb1d533ad/src/libraries/periphery/MorphoBalancesLib.sol#L90-L120

Rubilmax commented 10 months ago

What shall we do?

QGarchery commented 10 months ago

I don't think it's worth changing now