search

morpho-org / morpho-optimizers

Core contracts of Morpho V1 Optimizers.
https://app.morpho.org
GNU Affero General Public License v3.0
137 stars 22 forks source link

Revoke changes on Morpho in `upgrade-lens-0` #1571

Closed MerlinEgalite closed 1 year ago

MerlinEgalite commented 1 year ago

Check my comments on upgrade-lens-0: https://github.com/morpho-dao/morpho-v1/pull/1514

Basically, the goal is to remove changes on Morpho-AaveV2

Rubilmax commented 1 year ago

The changes impacting Morpho-AaveV2 are not changing the bytecode of the core contracts. These are only naming & comments

MerlinEgalite commented 1 year ago

But that means that the code deployed will not be the one audited by Spearbit which is not convenient for them

Rubilmax commented 1 year ago

Then why are we fixing natspec issues if it's to not deploy them?

MerlinEgalite commented 1 year ago

Which Natspec issues?

Rubilmax commented 1 year ago

The natspec issues fixed by the changes you've highlighted in src/aave-v2/MorphoUtils.sol

MerlinEgalite commented 1 year ago

I also put it as to revert if I'm not mistaken

Also, if we merge the PR as is we'll need to re-create the tx on the DAO multisig

Rubilmax commented 1 year ago

I also put it as to revert if I'm not mistaken

Yes, that's the problem I am raising. Why did I spend time on this if we're not deploying them?

Also, if we merge the PR as is we'll need to re-create the tx on the DAO multisig

This is incorrect as the bytecode is not impacted by these changes. Only the Etherscan source code verification would need to be performed again (but it's not performed yet)

MerlinEgalite commented 1 year ago

I also put it as to revert if I'm not mistaken

Yes, that's the problem I am raising. Why did I spend time on this if we're not deploying them?

This PR is dedicated to changes on the Lens, we should not have done changes to morpho first. I shouldn't have approved it.

For the natspec, I don't know where the issue comes from tbh

Also, if we merge the PR as is we'll need to re-create the tx on the DAO multisig

This is incorrect as the bytecode is not impacted by these changes. Only the Etherscan source code verification would need to be performed again (but it's not performed yet)

True

MerlinEgalite commented 1 year ago

Closing this issue