search

morpho-org / morpho-token-upgradeable

Other
7 stars 7 forks source link

`abstracts` folder #74

Closed MathisGD closed 3 weeks ago

MathisGD commented 3 weeks ago

Fixes #72

The purpose is to have only the deployed contract at src's root

colin-morpho commented 3 weeks ago

Really not sold on this idea, but not totally against either. I would move it to lib, historically this is the purpose of lib directories in source repos. After all, the lib directory is not reserved for foundry purposes. In fact the good practice is to move dependencies pulled via git modules in a lib/vendoring or lib/vendor sub directory to insist on the fact that these libs are provided as source code (as opposed to dynamically linkable binaries) that is not ours. Then we can put code not directly related to the contract in lib. I understand however that in Solidity projects this is not a common practice.

MathisGD commented 3 weeks ago

@colin-morpho indeed, it's really uncommon practice to have some solidity you wrote outside of src

MathisGD commented 3 weeks ago

@MerlinEgalite there are already 3 contracts that will be deployed. I really like that they are all (and only them) in src's root

MathisGD commented 3 weeks ago

https://morpholabs.slack.com/archives/C02N7CZ088N/p1730278971498489