Move mocks from `certora` and `test` folders to a common place

morpho-org / morpho-utils

Repository gathering useful libraries and contracts.

GNU Affero General Public License v3.0

64 stars 1 forks source link

Move mocks from `certora` and `test` folders to a common place #71

Closed MerlinEgalite closed 1 year ago

MerlinEgalite commented 1 year ago

There are code duplications in those 2 folders I propose migrating them to a common folder to avoid code duplication.

Should we move them to the test folder?

Rubilmax commented 1 year ago

We could also argue that foundry tests are now redundant, given that Certora formal proofs are better than forge fuzzing. With this in mind, I think we should also clear up foundry test cases to only keep those used for gas tracking

MerlinEgalite commented 1 year ago

We still have gas comparison which I find quite useful tbh but agree that for testing we could remove them